climbjios-sg / climbjios-app

The community for climbers 🧗
https://www.climbjios.com/
GNU General Public License v3.0
25 stars 4 forks source link

final final fixes for feat/f01 gym initial deployment #278

Closed nathantew14 closed 1 year ago

nathantew14 commented 1 year ago

Describe your changes

  1. fixed jio page constantly refreshing when trying to scroll by moving DashboardRouter out of Dashboard (I was the one that put it there)
  2. fixed tapping screen on InfiniteScrollcomponent causing the side shadows to disappear as it sets overlay: auto automatically, so I patched the package to remove that.
  3. fixed "New!" badge on gyms NavBar button reappearing by using localStorage instead of setState
  4. fixed app freezing while GymDetailsPage loaded by removing the use of react-router's loader and using useRequest directly, and added a GymDetailsPageLoader.

Issue ticket number and link

Screenshots (if appropriate):

Checklist before requesting a review