climsoft / Climsoft

Climsoft Desktop for Windows - http://www.climsoft.org
GNU General Public License v3.0
14 stars 28 forks source link

Error when I try to produce "Inventory of Missing Data" inventory product #681

Open Patowhiz opened 2 years ago

Patowhiz commented 2 years ago

@smachua @mhabimana I'm getting an error when @dannyparsons and I try to produce the "Inventory of Missing Data" inventory product. See screenshot below.

Looking at the code I noticed that this product is supposed to be generated by a procedure in the database level? So I presume my database script didn't have this procedure and current users have it? I wonder whether it would be useful to have this product done at the application level.

Thanks.

Error climsoft_error

Code climsoft_sub_error

mhabimana commented 2 years ago

@Patowhiz : This module is a contribution of our colleague from Lesotho @Ralenkoane (Victor), using procedures. It has some issues and need further improvement. Not sure you have all the procedures required for this products. Here is a sample of the product of this module: image

Patowhiz commented 2 years ago

@mhabimana thanks for the response. Do you have a sample output that I can have a look at?

Ralenkoane commented 2 years ago

Hi Marcellin,

What error does it throw. Guess it is something that I can fix without delays.

Rg

On Thu, Feb 10, 2022, 16:39 Marcellin @.***> wrote:

@Patowhiz https://github.com/Patowhiz : This module is a contribution of our colleague from Lesotho @Ralenkoane https://github.com/Ralenkoane (Victor), using procedures. It has some issues and need further improvement.

— Reply to this email directly, view it on GitHub https://github.com/climsoft/Climsoft/issues/681#issuecomment-1034998455, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKHGWIEUWXPKAOVG6KQ353U2PE2JANCNFSM5OA2QQBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

mhabimana commented 2 years ago

@Patowhiz : It is working on my side: see below the output I am getting,but still it is not working well as desired because if you select many elements for example,it does not give you a good result. image

mhabimana commented 2 years ago

@Ralenkoane: Good to hear from you, long time. We need to discuss further and see how this useful product can be improved if you have time.

mhabimana commented 2 years ago

@Ralenkoane - Not sure you saw and read @Patowhiz message on top,he is complaining not getting desired products but I guest he is missing one of the procedures in his database.

Patowhiz commented 2 years ago

@mhabimana thanks for the sample output. I guess I don't have the procedures. Can you share them to me, would be useful to me for testing the code. I have the latest changes from the master.

mhabimana commented 2 years ago

@Patowhiz - Sure.

mhabimana commented 2 years ago

@Patowhiz : Below are the procedures,you need to run each of them once to create required tables in your database,you can read the scripts, they are self explanatory. Let me know how you are getting on. I am sure @Ralenkoane will be happy to respond to any other of your questions on this.

smachua commented 2 years ago

@mhabimana and @Patowhiz this product was done through stored procedures, The development contributor (Victor, from Lesotho) was an expert in stored procedures and we allowed him use them. Note that we have been including these procedures in the installation and upgrade script files. If you run them the procedures will be created in your database. I have attached the upgrade script file in case you don't have it. mariadb_climsoft_db_v4_upgrade.txt