search

climsoft / climsoft-api

API for Climsoft databases
MIT License
2 stars 4 forks source link

Setup climsoft #3

Closed Shaibujnr closed 2 years ago

Shaibujnr commented 2 years ago
isedwards commented 2 years ago

@Shaibujnr I merged this PR earlier - I was just wondering why you removed the explicit declaration of fields in each model - was it causing a problem?

isedwards commented 2 years ago

@faysal-ishtiaq could you let me know your thoughts on this?

faysal-ishtiaq commented 2 years ago

@isedwards

I added the fileds for renaming columns/attributes. I made all the columns/attributes snake case, both when you send request and when you receive the response. But as far as I know they weren't causing problems.

Anyway, I noticed that we have also removed the setup and teardown functions from tests. Is that intentional?