climu / openstudyroom

Website for the Open Study Room online go/baduk/weiqi community.
https://openstudyroom.org
GNU General Public License v3.0
67 stars 33 forks source link

Join button shouldn't be shown if a league have no division #370

Closed climu closed 5 years ago

climu commented 5 years ago

Quoting alemitrani from #364 :

@climu I set up a pilot handicap league to test the new functionality: https://openstudyroom.org/league/120/games/ I already found an issue - it won't let me join the league. I get an error message that says "Oops ! Something went wrong. You didn't join." Help!

Thanks

Thanks @alemitrani. I will try to reproduce as soon as possible.

alexmitrani commented 5 years ago

I think I figured out what the problem was - I hadn't created a division. When I had created a division it let me join the league.

climu commented 5 years ago

Happy to hear that!

The join button shouldn't even be there when a league have no division.

I will edit your issue so it reflect the problem.