search

climu / openstudyroom

Website for the Open Study Room online go/baduk/weiqi community.
https://openstudyroom.org
GNU General Public License v3.0
67 stars 33 forks source link

confusion with both senses of primary leagues #419

Open angelsesma opened 3 years ago

angelsesma commented 3 years ago

/ladder subdirectory to be included in the href string

climu commented 3 years ago

Thanks for spotting that. Actually the issue is more of an undocumented and unused feature:

One league is called primary. There is a button in league admin tools to set it: image

The url /league/ will always direct to the primary league.

So the issue here is the primary league have not been updated for ages.

Mind that the name is quite confusing since it also refer to primary leagues where player are automatically enrolled. image

I think a better fix would be to control the url /league/. I see 2 ways:

  1. always redirect it to /ladder/
  2. Admins should update the One primary league everymonth.

I guess 1 is better.

Change would happen here: https://github.com/climu/openstudyroom/blob/0ae71e90fe36766d002d221b63ace9f18d517e45/league/views.py#L263-L264

with much inspiration from: https://github.com/climu/openstudyroom/blob/0ae71e90fe36766d002d221b63ace9f18d517e45/league/views.py#L307-L317

angelsesma commented 3 years ago

thanks for the heads up! will give it a shot :)