search

clineamb / gulp-s3-upload

A gulp task to upload/update assets to an S3 account.
62 stars 37 forks source link

PR caused ContentEncoding to break #23

Closed confuser closed 9 years ago

confuser commented 9 years ago

Referring to #22

This breaks setting a ContentEncoding option as the variable contentEncoding is only ever set if manualContentEncoding is defined. If not, it overrides objOpts.ContentEncoding regardless of if contentEncoding is a falsey value.

https://github.com/clineamb/gulp-s3-upload/blob/master/index.js#L169

jdrydn commented 9 years ago

:clap: With regards to the versioning too :cry:

clineamb commented 9 years ago

Thanks for this! I'll take a look at it after work today. Should be an easy fix -- the check for ContentEncoding is set and NOT manualContentEncoding.

clineamb commented 9 years ago

I fixed this issue in the latest 1.3.0 tag/release. This also inspired a new maps option.

Thanks guys!