search

clineamb / gulp-s3-upload

A gulp task to upload/update assets to an S3 account.
62 stars 37 forks source link

stream support #34

Closed algesten closed 8 years ago

algesten commented 8 years ago

We upload large video files using this plugin and need stream support. It appears the S3 API supports it, so the only thing stopping us is the ETag comparison. This PR does not do ETag comparison when handling streams.

clineamb commented 8 years ago

@algesten - Awesome, thanks for this! I'll review this later today and merge it in. (:

algesten commented 8 years ago

Adding that I want an upgrade to aws-sdk 2.3.3 since that version did som good fixes for streams. https://github.com/aws/aws-sdk-js/commit/408a438baafe52e5b0e9c3a9691d5d5842e7865e

clineamb commented 8 years ago

Made some version updates and merged this in! Thanks for this! :D

algesten commented 8 years ago

:D