clingen-data-model / allele

Documentation for data model of ClinGen
10 stars 2 forks source link

Review Allele UI/UX Branch Updates #185

Closed sgoehringer closed 6 years ago

sgoehringer commented 6 years ago

Hello @larrybabb @cbizon @nafisakhandaker @bpow @tnavatar ! I wrapped up the UI/UX updates for allele in a branch (https://github.com/clingen-data-model/allele/compare/BrandingQ42017) Take a look and let me know if you have any ideas/issues. If it looks good, pull it and and release.

NOTE - I didn't test this on a build with the home page... I wasn't clear on the docs for that so let me know if you have branding issues on that one.

AND - The one item I wasn't certain about was the line in config.rb on line 250 (https://github.com/clingen-data-model/allele/commit/988c97e39f7acc02890cc466f8132e4e6558eaef#diff-2620489c404159b5404f13f82e470fbdR250) where a direct reference to files in the live site is set. I quickly commented this out and made it / for dev. I am not 100% sure we need this, if we do, we may want to add some code so it turns off.

sgoehringer commented 6 years ago

Closing this one as well