clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

Circular references are back #134

Closed bpow closed 6 years ago

bpow commented 6 years ago

In the process of filling out CanonicalAllele and ContextualAllele attributes, it looks like there are circular references that prevent reformat_examples.rb from working.

bpow commented 6 years ago

Could also be due to produces/producedBy

bpow commented 6 years ago

I have handles this for now by hard-coding producedBy to just represent as a string.

larrybabb commented 6 years ago

I think it is both the contextualAllele produces and produces by as well as the ContextualAllele relatedCanonicalAllele and CanonicalAllele.preferredContextualAllele references. Note that the ReferenceSequence also has the produces/producedBy circular reference. But I'm not sure that one causes an issue or not.

larrybabb commented 6 years ago

@bpow if you feel this is re-handled. please feel free to close this.

bpow commented 6 years ago

closing this, but there remains the possibility that we might handle this better by internally using something more rdf-like (or yaml) that can handle loops better.