search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

VS024 needs entries #137

Closed bpow closed 6 years ago

bpow commented 6 years ago

LocHet104 has "complete" for its specificity, but as a String, not refering to a coded concept

bpow commented 6 years ago

Tagging @larrybabb and @cbizon to make sure they see.

larrybabb commented 6 years ago

There were 2 LocHet items LocHet148 and LocHet149 that had this issue. I corrected the missing Attribute data type issue and sample data to point to the appropriate iri @id value.

I think LocHet104 was a mis-reference above. If not please re-open and add more info to clarify.

bpow commented 6 years ago

@larrybabb please note when you do this or similar things, you cannot have SEPIO-CG:99002 or things like it as a value for A102-- it needs to refer to the DomainEntity (LSTID211) so the link can be followed using the internal id. I'll work on fixing these.

larrybabb commented 6 years ago

So sorry.

Sent from my iPhone

On Oct 9, 2017, at 4:39 PM, Bradford Powell notifications@github.com wrote:

@larrybabb please note when you do this or similar things, you cannot have SEPIO-CG:99002 or things like it as a value for A102-- it needs to refer to the DomainEntity (LSTID211) so the link can be followed using the internal id. I'll work on fixing these.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.