search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

Vestigial attributes in some entities #153

Closed cbizon closed 6 years ago

cbizon commented 6 years ago

There are some entities that are reproducing attributes from their parent domainentity. For isntance, in our Types.json, Family has a label and a description. In the sheet, these are struckthrough, but this is not being picked up by the json generator (maybe it shouldn't be- is there a reason these are still in the sheet?).

@larrybabb @bpow

larrybabb commented 6 years ago

i wanted to make sure it was seen by Matt Brush.
I will remove and keep the strikethrough on the SEPIO sheets only.
I think I also wanted to get explicit acceptance from both Bradford and you on changing the parent entity on Types like these.