search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

Criterion missing from website #154

Closed cbizon closed 6 years ago

cbizon commented 6 years ago

@nafisakhandaker
In reorganizing the documents, I think we lost Criterion (E04).

larrybabb commented 6 years ago

Almost all Types that have a parent of (E40-DomainEntity) can be found in the DomainEntity sheet. These separate sheets (e.g. Criterion, ScoringAlgorithm, Family, Individual, etc..) all got rolled up into the DomainEntity/_DomainEntityAttribute sheets, but the content should be the same.

If this addresses the issue please close, if not please clarify.

cbizon commented 6 years ago

Sorry, I meant on the website, we no longer have a page for Criterion.

larrybabb commented 6 years ago

oh. makes sense. @nafisakhandaker will add the Criterion page back in under DomainEntities.

nafisakhandaker commented 6 years ago

I don't see Criterion in google sheet. Should I add it anyway?

Nafisa Khandaker Email: nafkhan@gmail.com Cell: 617-501-7745 <6175017745>

On Mon, Oct 23, 2017 at 3:59 PM, Larry Babb notifications@github.com wrote:

oh. makes sense. @nafisakhandaker https://github.com/nafisakhandaker will add the Criterion page back in under DomainEntities.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clingen-data-model/clingen-interpretation/issues/154#issuecomment-338778712, or mute the thread https://github.com/notifications/unsubscribe-auth/AcWwKQ4Z1MIUkbwZctQ_XCbhchyzRfwXks5svPAugaJpZM4QDX79 .

nafisakhandaker commented 6 years ago

Added Criterion under Domain Entity

Nafisa Khandaker Email: nafkhan@gmail.com Cell: 617-501-7745 <6175017745>

On Mon, Oct 23, 2017 at 4:15 PM, Nafisa Khandaker nafkhan@gmail.com wrote:

I don't see Criterion in google sheet. Should I add it anyway?

Nafisa Khandaker Email: nafkhan@gmail.com Cell: 617-501-7745 <6175017745>

On Mon, Oct 23, 2017 at 3:59 PM, Larry Babb notifications@github.com wrote:

oh. makes sense. @nafisakhandaker https://github.com/nafisakhandaker will add the Criterion page back in under DomainEntities.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clingen-data-model/clingen-interpretation/issues/154#issuecomment-338778712, or mute the thread https://github.com/notifications/unsubscribe-auth/AcWwKQ4Z1MIUkbwZctQ_XCbhchyzRfwXks5svPAugaJpZM4QDX79 .

bpow commented 6 years ago

Seems like this was fixed a while ago