search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

Revisit types with "Type" in their names #155

Closed bpow closed 6 years ago

bpow commented 6 years ago

When @larrybabb did the most recent CodableConcept-related changes, he noted that some of the value sets already had names that matched current types, so he appended 'Type' to those names (for example, MolecularConsequenceType). However, this was not consistent because there was not already existing types with those names elsewhere (and in some cases, there is a 'Type' suffix where there is not an existing non-suffixed name -- for instance RegionAnnotationType).

To address the current MolecularConsequence/MolecularConsequenceType case, these could be changed to AlleleConsequence (or AlleleMolecularConsequence) and MolecularConsequence, respectively.

bpow commented 6 years ago

I believe this is fixed with recent CodableConcept -> DomainEntity subclass changes by @larrybabb