search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

@context and curies #182

Closed cbizon closed 6 years ago

cbizon commented 6 years ago

We use curies all over the place. Don't we need to define the prefix somewhere and isn't that somewhere the context? I don't think that they're in there.

Also, there's at least one stray "\n" floating around in there:

"Statement": { "@id": "SEPIO:0000174\n" },

bpow commented 6 years ago

The spare "\n" was easy to fix-- it was being faithfully represented since it is in the sheets document. I think the prefixes may have at one point been part of the IdentifierSystem objects, but there is also a separate _prefixes sheet. I don't recall what the difference is supposed to be (or if there is supposed to be a difference) but will look into this.

bpow commented 6 years ago

5bfad98 should close this, so long as all relevant cURI prefixes needing to be included in the context are associated with an IdentifierSystem.

@cbizon : do you see any prefixes that still need to be mapped, if not, then this issue can be closed.