search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

ValueSet.label is defined in _ValueSetAttributes rather than the labels sheet #199

Closed bpow closed 6 years ago

bpow commented 6 years ago

It looks like someone (@larrybabb ?) renamed the conceptType column in the ValueSet sheet to label.

However, labels should all be defined in the __labels sheet rather than individual types' sheets.

Also, the ValueSet.conceptType attribute still exists in the Attribute sheet, so I don't know if this renaming was intentional.

larrybabb commented 6 years ago

I think that was me. I did it on our last call and was not aware of the label sheet.

The renaming on the attributes sheet was an oversight and needs to be made still.

The labels have been updated to the recommendations from MBrush at the last meeting and put in the __label sheet. And the label column has been removed.

I also updated the IRIs on the value sets to reflect the permanent IRIs from MBrush that are available.