search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

AlleleConservation conservationOutcome refactor #206

Closed larrybabb closed 6 years ago

larrybabb commented 6 years ago

@bpow Changed the AlleleConservation.conservationType to conservationOutcome and added the additional value set concepts to allow the "negative and unknown" outcomes to be options.

Note: in doing this, I discovered the duplication of "conservationType" on the AlleleConservationScore which was removed. We currently use the Statement.evidenceLine to provide a mechanism for showing the AlleleConservationScore that was used to make the qualifiying statement AlleleConservation. So I did not think it wise to duplicate the qualified outcome on the Score statement since it is a conflation of statement types. @bpow can you weigh in on this?

larrybabb commented 6 years ago

we can close once @bpow and/or @cbizon inspects (we can do this at our next meeting)

larrybabb commented 6 years ago

completed in our discussions and folded into the higher level change defined by #218