search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

NullAllele annotationOutcome refactor #207

Closed larrybabb closed 6 years ago

larrybabb commented 6 years ago

@bpow changed the NullAllele annotation to annotationOutcome and added the value set concepts to allow for not LOF and unknown LOF concepts to be provided by the value set. Converted any "NOT" qualified records accordingly. And, found some data integrity issues, which caused me to revisit all NullAllele records to assure they were connected to the correct examples.

We may want to review this as I ended up creating 2 NullAllele objects that we never captured. I presumed these were missed as the pattern seemed to be related to the tagging of our original MolecularConsequence.LOF boolean attribute which was transformed to the NullAllele statement.

larrybabb commented 6 years ago

we can close once @bpow and/or @cbizon inspects (we can do this at our next meeting)

larrybabb commented 6 years ago

completed in our discussions and folded into the higher level change defined by #218