search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

Change Statement.source from string to @id? #208

Closed larrybabb closed 3 years ago

larrybabb commented 6 years ago

It seems like we should be using A127 Statement.source for PubMed IRIs when available to show the source of given statements (i.e. Information).

There are 9 A120 Statement.description elements in our example data that have only PMID:xxxxx values which should also be changed to A127.

Should we review and consider making A127 an @id? Will it need a ValueSet, it may be very difficult to define a ValueSet since the source can be almost anything.

larrybabb commented 6 years ago

@bpow @cbizon I meant to ask for you guys to weigh in on this. I'm thinking that A127 should be @id and we should define an "external" value set that is also extensible in that it can come from almost anywhere? what do you think?

bpow commented 6 years ago

Yes, I think Statement.source should be @id. It will be a fairly open ValueSet, but pubmed obviously would be preferred.

larrybabb commented 6 years ago

Still not done. Where do we stand on this?