search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

EvidenceLine.description cardinality #213

Closed cbizon closed 6 years ago

cbizon commented 6 years ago

Currently set to 1..1, i.e. description is required on EvidenceLine. 1) Is this what we want? 2) If so, what should we do when transforming a VCI that doesn't have anything good for description? Use ""?

I think I'd argue to make EvidenceLine.description be 0..1

larrybabb commented 6 years ago

You should feel free to tweak/modify the constraints, we did not really pay too much attention to them as we went along. So, trust your judgement and change as you see fit.

larrybabb commented 6 years ago

This issue was indirectly resolved by adding the "Entity" superclass above all and hanging both label and description attributes off it. This enables all concepts to have 0..1 labels or descriptions. The explicit "description" attribute on EvidenceLine was removed and replaced with that.