search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

Need SEPIO attributes for UserLabel (I think) #221

Closed larrybabb closed 6 years ago

larrybabb commented 6 years ago

@mbrush Can you verify whether or not we have specific attributes identified for UserLabel and have them in the queue for SEPIO iris?

I think we have contribution and labelFor in our model, even though we don't have any examples that exercise their use.

mbrush commented 6 years ago

I can add a UserLabel type/class to the SEPIO-ClinGen owl file, along with a userLabel attribute/property. This seems to be the only 'new' attribute needed for modeling UserLabels ( other attributes i see in our example are already part of the model - type, label, contribution, description.

LMK if this is correct, and there are other terms that need to be created besides UserLabel and labelFor.

mbrush commented 6 years ago

OK, just added the label_for object property (SEPIO:0000420) and 'user label' class (SEPIO:0000421). Not sure where to document these in the ClinGen spreadsheets, so hoping @larrybabb will do this for me. Thanks!

larrybabb commented 6 years ago

I've added the 2 items above to our sheets. However, in the comment 2 above, @mbrush suggests that UserLabel is a subclass of something we already have in our model (Statement or DomainEntity). I'm thinking UserLabel descends from DomainEntity, which only has one property right now "description". Do we need "contribution" on our UserLabel class?

The top-level classes in our model (based on the sheets) are: Statement DomainEntity Contribution Agent ValueSet EvidenceLine

I stuck UserLabel under DomainEntity...which only has a "description" property defined on it thus far.

larrybabb commented 6 years ago

This has been resolved in our Thu discussions.