search

clingen-data-model / clingen-interpretation

Allele (variant) interpretation model and API for ClinGen
3 stars 1 forks source link

should "description" be special-cased the same way as "label"? #224

Closed bpow closed 6 years ago

bpow commented 6 years ago

When we got rid of a parent type, there was no longer any place to put "label", so it was decided (passive voice...) for "label" to be a special case, with its own sheet.

But the same argument could be made for "description".

Quick discussion on call 2018.05.14 was to have everything in the model descend from BFO:000001 (Entity), and in our model to have that have attributes "label" and "description".

larrybabb commented 6 years ago

This change has been made in the driver "sheet". The "labels" sheet is being renamed to entityAttributes. I will close this issue once the ruby script that transforms the "sheet" into the required artifacts is modified to handle this change in the model.

bpow commented 6 years ago

With re-instatement of Entity, label and description go there.

Effectively closed with 07482419