clingen-data-model / clinvar-ingest-reports

ClinGen generates several google sheet based reports from the ClinVar ingested data that originates from the Broad BigQuery data.
0 stars 0 forks source link

External users can't refresh vcep or other clinvar-based google sheets #88

Closed larrybabb closed 3 months ago

larrybabb commented 4 months ago

Any non-broadinstitute.org based user seems to recently been presented with an exception when they try to "Refresh" a VCEP google sheet (e.g. ACADVL and FH users).

My initial analysis proves that this is occurring on any external google account not affiliated with broadinstitute.

larrybabb commented 4 months ago

A month ago or less I did some major updates to how the data is being retrieved which introduced a new resource that requires additional access (the ClinVar Report BQ Support Tables google sheet in the B/G shared google drive). This introduced the breaking change since the "Refresh" function now needs the ability for the user to read that sheet. So, to try to make things simpler all around, I think we should simply add any google account users that need to work with any of our clinvar-based google sheets to the clingen-data-read@broadinstitute.org google group. I've assigned this google group to the ClinVar Report BQ Support Tables google sheet in the B/G shared google drive with View permissions and we should make sure this google group has editor permissions on the VCEP Report shared drive in the ClinGen Site shared google drive (versus individually adding accounts to that folder). And we can stop adding folks that do not need the chrome extension access to the Oauth Consent list of test users.

larrybabb commented 4 months ago

@dazzariti if you and/or @hdziadzio could work to create a list of google accounts for all vcep and other google sheet users and add them to the clingen-data-read@broadinstitute.org google group. Additionally, one of you will also need to make sure this google group email is added as an Editor to the VCEP Variant Tracking Reports folder in the ClinGen Site shared google drive (once that is done the individual entries that are in that shared drive can be removed). This google group is also currently added as a Viewer on the ClinVar Report BQ Support Tables which will fix the breaking change that caused this bug to happen. You should also be able to remove all google account users from the GCP Oauth Consent test users list that do not need access to the chrome extension. I mistakenly instructed us to do this for all users that needed access to the clinvar ingest data (which is now really based on this google group membership). NOTE: all chrome extension users still need to be in the Oauth Consent list (which might possibly be managed by adding a new google group to the test list so that we don't have to manage membership through the GCP Oauth screen - but we will need to test this if it is desirable).

dazzariti commented 3 months ago

Thanks Larry, just an update -