clingen-data-model / clinvar-ingest-reports

ClinGen generates several google sheet based reports from the ClinVar ingested data that originates from the Broad BigQuery data.
0 stars 0 forks source link

Add ClinVar Organization IDs to VCEP Variant Trackers #94

Closed dazzariti closed 3 months ago

dazzariti commented 3 months ago

Hi Ryan! These are existing VCEP Variant Tracker reports but were created before VCEP started submitting to ClinVar, I've added the ClinVar organization IDs to the ClinVar Report BQ Support Tables but not sure if you also need to add the submitter ID anywhere else - if not, you can just close this!

RyanFWebb commented 3 months ago

Thanks for highlighting this Danielle! I don't believe we need to update the sheet itself, but I had to regenerate the reports in BigQuery anyway for the ENIGMA sheet so everything should be working smoothly.

Of note, it looks like a coordinator was filtering through the priorities extract sheet in the LCA/eoRD which we want to avoid because this could potentially alter how the sheets work.

dazzariti commented 3 months ago

Thank you! I'll add to the document that the hidden tabs should not be edited.

RyanFWebb commented 3 months ago

It looks like the formatting on the priorities sheet got shifted as a result, with the first entry in a new filter created by the group being highlighted in the header's shade of purple and the Track button getting displaced.

It looks like the coordinator is still in the sheet so I don't want to meddle with it while they're working through it, but this may require me going back in to take a look at another time.

dazzariti commented 3 months ago

Thanks! I just sent her this email

"Hi Lori, I just want to reach out about using the LCA/eoRD VCEP Variant Tracker report, I had a member of our development team review some of the newer reports to ensure the ClinVar submitter IDs had been incorporated. He noticed that some of the hidden tabs on the LCA/eoRD report had been edited - just want to reach out and let you know these aren't intended to be edited, as it could affect how the report generates data on the Home, Alert, Priorities and Tracking tab. If you're noticing any issues with the report, just let me know. I did just add a note about that to the How To guide. Thank you, Danielle"