Major refactor of clinvar_raw to simplify code flow

clingen-data-model / clinvar-streams

1 stars 0 forks source link

Major refactor of clinvar_raw to simplify code flow #60

Closed theferrit32 closed 1 year ago

theferrit32 commented 2 years ago

Removes use of core.async channels and futures
Converts some functions into pure functions with no side effects

larrybabb commented 2 years ago

@theferrit32 is there an issue on the github board to associate with this?

theferrit32 commented 2 years ago

@larrybabb this was done as part of the work to ingest the larger test dataset. It significantly speeds things up, and makes it less error prone. I would like to clean this up before merging to master but it is not a high priority because it is not blocking anything else right now.

An issue could be added and put in the backlog.

theferrit32 commented 1 year ago

I've addressed feedback from Tom aside from the file processing. That should be revisited later to more match other patterns for large sequence or file processing in our code. https://github.com/clingen-data-model/clinvar-streams/issues/63