search

clingen-data-model / curator

0 stars 0 forks source link

Create github action for automated build and tagging of docker image #5

Closed theferrit32 closed 3 years ago

theferrit32 commented 3 years ago

Push image to gcr.io/clingen-dev/curator with commit hash tag.

theferrit32 commented 3 years ago

Sort of depends on https://github.com/clingen-data-model/curator/issues/6

theferrit32 commented 3 years ago

There is also a Google Cloud Build github app that might reduce complexity from having to manage github action secrets.

https://github.com/marketplace/google-cloud-build

The cloud build pipeline could probably be made to trigger a github action when done, to update the image tag in the deployment file.

tnavatar commented 3 years ago

I missed something, why are we considering using Docker for the admin app? Is this just to automate the build? As far as hosting is concerned, Firebase hosting or a public cloud storage bucket would be more appropriate.

theferrit32 commented 3 years ago

Firebase is fine with me for this one. We'll need automated build and deploy via docker+kubernetes for several other repositories. Maybe we replicate this issue to clinvar-streams for a docker based action there.

There is a GitHub action for firebase: https://github.com/marketplace/actions/github-action-for-firebase

It looks like firebase domains are just for the entire project, i.e. it seems we can't have multiple deploys simultaneously in the same GCP project. We'll need a plan for where we deploy these to. Maybe master commits/merges go to clingen-stage firebase, leaving open clingen-dev firebase for active development.

sjahl commented 3 years ago

OK, the docker build stuff is pretty generic, so it can definitely be applied elsewhere. I'll start looking into firebase deployments.