Connects to #31. Fields required to display segregation LOD score data due to revised SOP.

[jimmyzhen]

I am proposing the following 5 new fields:

"LodScoreTotal"
"LodScoreSumOfCandidateSequencingMethod"
"LodScoreSumOfExomeSequencingMethod"
"FamilyCountOfCandidateSequencingMethod"
"FamilyCountOfExomeSequencingMethod"

Furthermore, given the revised segregation scoring logic, I think the "Tally" field is no longer appropriate. So I am proposing to remove the "Tally" field, and rename the "Value" field to the following:

"PointsCounted"

[sgoehringer]

We actually still need both because your interface and the website both show the total number of points that the system computed and the points counted (which can’t be more than the max). I propose we update them to match the GCI naming.

TotalPoints PointsCounted

Scott

Scott Goehringer t: 781-453-2960 On Twitter: @srgoehringer https://twitter.com/srgoehringer

IMPORTANT WARNING: The information in this message (and the documents attached to it, if any) is confidential and may be legally privileged. It is intended solely for the addressee. Access to this message by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken, or omitted to be taken, in reliance on it is prohibited and may be unlawful. If you have received this message in error, please delete all electronic copies of this message (and the documents attached to it, if any), destroy any hard copies you may have created and notify me immediately by replying to this email. Thank you.

On Aug 13, 2018, at 7:19 PM, Jimmy Zhen notifications@github.com wrote:

I am proposing the following 5 new fields:

"LodScoreTotal" "LodScoreSumOfCandidateSequencingMethod" "LodScoreSumOfExomeSequencingMethod" "FamilyCountOfCandidateSequencingMethod" "FamilyCountOfExomeSequencingMethod" Furthermore, given the revised segregation scoring logic, I think the "Tally" field is no longer appropriate. So I am proposing to remove the "Tally" field, and rename the "Value" field to the following:

"PointsCounted" You can view, comment on, or merge this pull request online at:

https://github.com/clingen-data-model/data-exchange-shared-json/pull/32 https://github.com/clingen-data-model/data-exchange-shared-json/pull/32 Commit Summary

Add/update fields to segregation scoring data due to revised SOP File Changes

M json-structure-phase1/Gene Curation Interface/gci-sop-v5.json https://github.com/clingen-data-model/data-exchange-shared-json/pull/32/files#diff-0 (8) Patch Links:

https://github.com/clingen-data-model/data-exchange-shared-json/pull/32.patch https://github.com/clingen-data-model/data-exchange-shared-json/pull/32.patch https://github.com/clingen-data-model/data-exchange-shared-json/pull/32.diff https://github.com/clingen-data-model/data-exchange-shared-json/pull/32.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/clingen-data-model/data-exchange-shared-json/pull/32, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEM20fe55LYOlVdYtGDmvIVHGT35y7kks5uQglzgaJpZM4V7jX0.

[jimmyzhen]

Hi @sgoehringer,

Regarding the Total Points column for the segregation LOD score in the GCI's classification matrix, it is currently showing pointsCounted (totalPoints) in production, such as 2 (4.65).

With the revised logic and display, the totalPoints has been moved to the Total Summed LOD Score row from the Total Points column.

Without any further specs on what should be shown in the Total Points column after the totalPoints value is moved, we are just simply leaving the pointsCounted value in the same table cell. So, the value being shown in the Total Points and the Points Counted columns for segregation LOD score is essentially the same pointsCounted value.

[jimmyzhen]

Opting for the latest revisions to the object model by @sgoehringer. Closing this PR.