search

clingen-data-model / data-exchange-shared-json

JSON schema utilized to share data from the curation interfaces into the Data Exchange. CONTAINS GENE EXPRESS JSON DATA
1 stars 0 forks source link

Defining = "CurationGroup": #6

Closed sgoehringer closed 6 years ago

sgoehringer commented 7 years ago

"CurationGroup": { "Id": "GCWGid1", "Name": "Cardiovascular - Aortopathy" },

We need to define an appropriate ID schema for the curation group to use. This would be used by the GCI and the website to be able to appropriately match work. The website may not need the name but might as well share it so it is easier to confirm matches and structure.

jimmyzhen commented 7 years ago

The ClinGen GCI currently does not have CurationGroup defined, but we have talked about a light implementation of groups in which the curators belong.

sgoehringer commented 7 years ago

Great point! Matt seemed like he was thinking about this... should I circle up with him and work options?

jimmyzhen commented 7 years ago

Sounds good.

sgoehringer commented 7 years ago

Matt, I just assigned this to us as a reminder to follow up about possible ideas/solution on how to handle groups.

wrightmw commented 7 years ago

@sgoehringer Hey Scott, sure... more than happy to liaise on this.

sgoehringer commented 6 years ago

@wrightmw I am bring in some notes from an email exchange on Sept 28...

I want to ask you about the nomenclature you use for IDs for Groups. We would prefer that these are named as Affiliation IDs instead of Group IDs. We already use 'Group' for something different in our database. Also, in our interfaces we will need IDs not just for ClinGen working groups but also for other organizations (such as private labs). Therefore we would prefer to use the term Affiliation ID, which would enable us to label all of the affiliations that a curator might have.

I agree with this alteration.

sgoehringer commented 6 years ago

Addressed - 2da23a2d93e3638cf5f240c3ac29c99be1b36aaf and d15ad13bb58150bc3fe1be2889eb126ac46c965b