clingen-data-model / genegraph

Presents an RDF triplestore of gene information using GraphQL APIs
5 stars 0 forks source link

Swap to hato http client for rocksdb http registry #760

Closed theferrit32 closed 1 year ago

tnavatar commented 1 year ago

Seems fine, but what's the motivation for this?

toneillbroad commented 1 year ago

See Kyle's comments on genegraph-dev slack channel.

On Wed, Mar 22, 2023 at 6:21 PM tnavatar @.***> wrote:

Seems fine, but what's the motivation for this?

— Reply to this email directly, view it on GitHub https://github.com/clingen-data-model/genegraph/pull/760#issuecomment-1480333836, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALM6D5OLC4FXMZQOCLKT2UDW5N3PXANCNFSM6AAAAAAWENPYPU . You are receiving this because your review was requested.Message ID: @.***>

theferrit32 commented 1 year ago

@tnavatar using this hato library with http/2 is significantly faster than clj-http, when doing a lot of requests in a short period of time. For a batch of variants, loading each performs between 1-3 http requests (check cache, normalize if not in cache, put in cache) per variant on the backend in order to get the normalized form of the variant.