search

clinical-biomarkers / biomarker-datasetviewer

Biomarker Backend Dataset Viewer
https://hivelab.biochemistry.gwu.edu/biomarker-partnership/data
MIT License
0 stars 0 forks source link

File history list #8

Closed seankim658 closed 9 months ago

seankim658 commented 10 months ago

image On the Release History page, when you click on details it routes to https://hivelab.tst.biochemistry.gwu.edu/BCO_000435/0.1/history when it should be linking to https://hivelab.tst.biochemistry.gwu.edu/biomarker-partnership/data/BCO_000435/0.1/history.

I found where the tag for the detail link is defined, it is on line 454 in the /api/glyds/dataset.py file. The line is:

row.append("<a href=\"/%s/%s/history\">details</a>" % (obj["bcoid"],ver_one))

However, when I change it to this:

row.append("<a href=\"/biomarker-partnership/data/%s/%s/history\">details</a>" % (obj["bcoid"],ver_one))

The link redirects to https://hivelab.tst.biochemistry.gwu.edu/biomarker-partnership/data/biomarker-partnership/data/BCO_000435/0.1/history, which is duplicating the /biomarker-partnership/data part. I believe this is because the proxypass in the hivelab.conf file redirects /biomarker-partnership/data requests to /biomarker-partnership/data so that part is being duplicated.

Need to figure out how to fix this. Should I use an absolute URL for the href value instead of relying on the relative routing? For example, using https://hivelab.tst.biochemistry.gwu.edu/biomarker-partnership/data/biomarker-partnership/data/$BCO_ID/$VER/history directly in the href value.

seankim658 commented 10 months ago

@rykahsay Do you have any ideas on how to fix this? I suspect the easiest solution would be to supply an absolute URL to the a href tag instead of the relative routing.