Closed jongwooo closed 1 year ago
@jongwooo as you can see the workflows are failing because npm ci only works with a lockfile, which we don't have in this repo. @RafaelGSS any thoughts? Shall we add it so we can also enable this optimization or are we happy without?
@simoneb Oh, I forgot that there was no lockfile...!
@jongwooo as you can see the workflows are failing because npm ci only works with a lockfile, which we don't have in this repo. @RafaelGSS any thoughts? Shall we add it so we can also enable this optimization or are we happy without?
If there is no plan to add a lockfile, I will close this PR.
Usually, we don't use lockfiles on npm modules.
@simoneb Thank you for your careful comment! And @RafaelGSS, duly noted. Thank you! I will close this PR.
Just to expand on that, see: https://github.com/sindresorhus/ama/issues/479#issuecomment-310661514.
Signed-off-by: jongwooo jongwooo.han@gmail.com
Details
Updated
ci.yml
to cache dependencies using actions/setup-node.setup-node@v3
or newer has caching built-in.AS-IS
TO-BE
References