search

clinicjs / node-clinic

Clinic.js diagnoses your Node.js performance issues
https://clinicjs.org
MIT License
5.68k stars 125 forks source link

autocannon spurious failures #91

Open mcollina opened 5 years ago

mcollina commented 5 years ago

I've noticed a few flaky tests on CI (see https://github.com/nearform/node-clinic/issues/90):

# Subtest: clinic doctor --on-port
        ok 1 - should not error
        not ok 2 - expect truthy value
          ---
          at:
            line: 112
            column: 7
            file: test/cli-doctor-full.test.js
          stack: |
            test/cli-doctor-full.test.js:112:7
            test/cli.js:74:7
            node_modules/async/dist/async.js:3888:9
            node_modules/async/dist/async.js:473:16
            iterateeCallback (node_modules/async/dist/async.js:992:24)
            node_modules/async/dist/async.js:969:16
            node_modules/async/dist/async.js:3885:13
            ChildProcess.<anonymous> (test/cli.js:65:13)
          source: |
            t.ok(stderr.indexOf('Running 1s test @ http://localhost:') > -1)
          ...

        ok 3 - should be equal
        1..3
        # failed 1 of 3 tests
    not ok 5 - clinic doctor --on-port # time=4932.829ms

    # Subtest: clinic doctor --autocannon
        ok 1 - should not error
        not ok 2 - expect truthy value
          ---
          at:
            line: 129
            column: 7
            file: test/cli-doctor-full.test.js
          stack: |
            test/cli-doctor-full.test.js:129:7
            test/cli.js:74:7
            node_modules/async/dist/async.js:3888:9
            node_modules/async/dist/async.js:473:16
            iterateeCallback (node_modules/async/dist/async.js:992:24)
            node_modules/async/dist/async.js:969:16
            node_modules/async/dist/async.js:3885:13
            ChildProcess.<anonymous> (test/cli.js:65:13)
          source: |
            t.ok(stderr.indexOf('Running 1s test @ http://localhost:') > -1)
          ...

        ok 3 - should be equal
        1..3
        # failed 1 of 3 tests
    not ok 6 - clinic doctor --autocannon # time=4695.413ms
DylanC commented 4 years ago

@goto-bus-stop

Is there a problem with this particular test? test('clinic doctor --on-port', function (t) {

..or is this CI related?