search

clintbellanger / flare

Free Libre Action Roleplaying Engine
http://clintbellanger.net/rpg/
GNU General Public License v3.0
166 stars 41 forks source link

Add a few additional types to the toString function #862

Closed ghost closed 12 years ago

ghost commented 12 years ago

There was a bug (probably introduced during refactoring) that prevented settings of several data types from being saved. The toString function was not handling values of unsigned short and unsigned char types, so I added support for those two data types as well as a few other ones (for consistency with tryParseValue function).

stefanbeller commented 12 years ago

My bad. I am sorry for constantly breaking stuff. Directly above the toString there is the tryParseValue function, which does it the other way round. And apparently I fixed that, but not in this place.

Maybe we should also add a warning into the 'else' branch at the end, so in case there are more data types not recognized the developer gets a warning at testing.

ghost commented 12 years ago

Yes, I think adding a warning is a good idea. Should I do it?

stefanbeller commented 12 years ago

@milan-izai yes, please do so :)