clintbellanger / flare

Free Libre Action Roleplaying Engine
http://clintbellanger.net/rpg/
GNU General Public License v3.0
166 stars 41 forks source link

Refactoring. #912

Closed stefanbeller closed 11 years ago

stefanbeller commented 11 years ago

This pull request might need some close review.

This removes some lines of code and hopefully makes it a little more readable. Also some compiler warnings, yielded by gcc version 4.1 (sparc32vm, 2006) , have been removed. This were mostly warnings about missing implicit casts from float to integer.

Where possible I changed the order of the variables making the use of floats unneeded, i.e. first all integer multiplications and afterwards the divisions. This has the same precision as first casting all to float doing mult and div in random order and then casting back to int.

stefanbeller commented 11 years ago

Just added 3 commits. The commit 69e100d is best reviewed with disabled whitespace changes; then the commit is only a few lines.