clinthuffman / PAL

Performance Analysis of Logs (PAL) tool
MIT License
479 stars 101 forks source link

Cannot import Perfmon templates #53

Closed jack-the-cat closed 4 years ago

jack-the-cat commented 4 years ago

Attempting to import a Perfmon template generated using the "Export to Perfmon template file..." button on the Threshold File tab fails by greying out the Next and Finish buttons on the Create new Data Collector Set wizard (see image) PAL_Template_not_importing This seems to be caused by the and lines in the template XML file, referencing wdc.dll. If those lines are removed (or the XML fields left empty), the import works as expected.

Tested and confirmed as an issue when generating templates on a Windows Server 2016 instance (not tested generation on other instances), and confirmed as an issue importing to Windows Server 2012, 2012R2, 2016, 2016 HyperV and 2019, using the local PerfMon console, and a remote PerfMon console. (The 2016 HyperV instance doesn't have a local console, so only remote tested) Tested using the SystemOverview template, and the SQL Server 2014 template, on PAL 2.8.1

Attached are two XMLs based on the SystemOverview template, one as exported from PAL, and one with manual corrections to make it import. Zipped because Github doesn't like loose XMLs. Test XMLs.zip

clinthuffman commented 4 years ago

Hi twaitsey,

Thank you for reporting this. Have you tried the latest version of PAL, 2.8.2.1? I just tested it on Windows 10 19H1 and I confirmed that the wdc.dll line is not there. I fixed this a few times now and I’m hoping this latest update actually fixes it this time.

Thank you, Clint Huffman


From: twaitsey notifications@github.com Sent: Monday, October 7, 2019 3:28:26 AM To: clinthuffman/PAL PAL@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [clinthuffman/PAL] Cannot import Perfmon templates (#53)

Attempting to import a Perfmon template generated using the "Export to Perfmon template file..." button on the Threshold File tab fails by greying out the Next and Finish buttons on the Create new Data Collector Set wizard (see image) [PAL_Template_not_importing]https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F10653980%2F66304098-61ae7c00-e8f4-11e9-8468-c298acecd58f.PNG&data=02%7C01%7C%7C72dd824a8ffe4a86c06608d74b111733%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637060409077924634&sdata=LIPkZcAKozxJZOzaLbWBIip59tgfk91I1yX9CCbPs8s%3D&reserved=0 This seems to be caused by the and lines in the template XML file, referencing wdc.dll. If those lines are removed (or the XML fields left empty), the import works as expected.

Tested and confirmed as an issue when generating templates on a Windows Server 2016 instance (not tested generation on other instances), and confirmed as an issue importing to Windows Server 2012, 2012R2, 2016, 2016 HyperV and 2019, using the local PerfMon console, and a remote PerfMon console. (The 2016 HyperV instance doesn't have a local console, so only remote tested) Tested using the SystemOverview template, and the SQL Server 2014 template, on PAL 2.8.1

Attached are two XMLs based on the SystemOverview template, one as exported from PAL, and one with manual corrections to make it import. Zipped because Github doesn't like loose XMLs. Test XMLs.ziphttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclinthuffman%2FPAL%2Ffiles%2F3696713%2FTest.XMLs.zip&data=02%7C01%7C%7C72dd824a8ffe4a86c06608d74b111733%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637060409077934645&sdata=zFVGnmhIxNeo0Ay4MdbL8d9Xnl8vftRZ2Wy6R2kwEs0%3D&reserved=0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclinthuffman%2FPAL%2Fissues%2F53%3Femail_source%3Dnotifications%26email_token%3DAEXDYVFGBQEQTU7KSQLCR73QNMFMVA5CNFSM4I6CTBJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQAXBTA&data=02%7C01%7C%7C72dd824a8ffe4a86c06608d74b111733%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637060409077944649&sdata=sMMB4dsz3pCMHwlze5iCYq9dVgfJJjNEIVR7MzZG9vg%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEXDYVAFNR5D47KEFYGG3RTQNMFMVANCNFSM4I6CTBJQ&data=02%7C01%7C%7C72dd824a8ffe4a86c06608d74b111733%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637060409077954654&sdata=q1%2FnDfnyZAAy2r9OjjDntcUEvkcwcuyWVzsLTpNPGLI%3D&reserved=0.

jack-the-cat commented 4 years ago

That looks promising :) You might want to make that a release, as it looks like it works

Cheers, Peter