clinthuffman / PAL

Performance Analysis of Logs (PAL) tool
MIT License
479 stars 101 forks source link

Issues 56 and 57: Support executing PAL.ps1 from different directory and allow PS session log retention #58

Closed VonOgre closed 2 years ago

VonOgre commented 4 years ago

Reintroduced capabilities added originally in PR#12, but lost during the v2.8.1 release.

Added support for calculating relative paths to various threshold files based on the location of PAL.ps1 instead of the PowerShell session's current working directory. This allows for PAL to be executed from anywhere without issue, which is beneficial for larger automation.

Added support for NOT clearing the PowerShell session at the beginning of execution, so a bigger automation script doesn't lose everything prior to PAL starting.

Re-enabled the debug logging to the user's temp directory, but added a timestamp to the file name, so that each execution doesn't wipe out the previous log.

Resolves #56 Resolves #57

VonOgre commented 2 years ago

No worries! I'd honestly completely forgotten that I had outstanding pull requests so I was surprised to get emails today :P

On Wed, Sep 22, 2021 at 1:53 PM Clint Huffman @.***> wrote:

@.**** approved this pull request.

Thank you for the assistance! Sorry for the delay, I never received a notification about this and just now found it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clinthuffman/PAL/pull/58#pullrequestreview-761395956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENTWN7REPAU4RNEWIKJZMDUDI63FANCNFSM4LDFNPLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.