search

clinthuffman / PAL

Performance Analysis of Logs (PAL) tool
MIT License
479 stars 101 forks source link

The vmware.xml has a bug on VM Processor #61

Open jeffstokes72 opened 4 years ago

jeffstokes72 commented 4 years ago

Something seems to have changed in VMWare's perfmon counters. The template was made to collect individually named VM Processor counter objects. I think the name changed at some point on these.

The easy button is to have the data collector change from the individual call-outs to just

    <Counter>\VM Processor(*)\*</Counter>

as opposed to

<Counter>\VM Processor\% Processor Time</Counter>
<Counter>\VM Processor\CPU stolen time</Counter>
<Counter>\VM Processor\Effective VM Speed in MHz</Counter>
<Counter>\VM Processor\Host processor speed in MHz</Counter>
<Counter>\VM Processor\Limit in MHz</Counter>
<Counter>\VM Processor\Reservation in MHz</Counter>
<Counter>\VM Processor\Shares</Counter>

It's a lame fix but it's all I have (I don't run vmware here).

clinthuffman commented 3 years ago

Each analysis in PAL must focus on a counter name, therefore \VM Processor()\ will not work. I good update to the PAL Threshold File Editor would be to add a new analysis for each counter name. But at this point, I would rather completely rewrite PAL than fix this.

jeffstokes72 commented 3 years ago

The thing is @clinthuffman , its the collection that's bugged, not the analysis. Can you just change the output of the template to include the *, but still do the individual counter analysis by exact name?

clinthuffman commented 3 years ago

For some reason, analysis by exact name is not working in PAL. I’m not sure why I didn’t allow for it. Sounds like I’m overdue to rewrite it again.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Jeff @.> Sent: Wednesday, May 19, 2021 3:48 PM To: @.> Cc: Clint @.>; @.> Subject: Re: [clinthuffman/PAL] The vmware.xml has a bug on VM Processor (#61)

The thing is @clinthuffmanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclinthuffman&data=04%7C01%7C%7Cb8dd5100f20b4319d1b008d91b18451e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637570613312307206%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Xyc81Rg06BC6Lbpw9agZMhoOovfFp%2BSB2Fm%2FAJL50yg%3D&reserved=0 , its the collection that's bugged, not the analysis. Can you just change the output of the template to include the *, but still do the individual counter analysis by exact name?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclinthuffman%2FPAL%2Fissues%2F61%23issuecomment-844548294&data=04%7C01%7C%7Cb8dd5100f20b4319d1b008d91b18451e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637570613312307206%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8GAIQE4ChDa3FE2MfiNZ3y6Jc0U9JHf5L1JqL7Cwuvg%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEXDYVDWE7BQSZHOD7DESV3TOQ55DANCNFSM4NMMMOGQ&data=04%7C01%7C%7Cb8dd5100f20b4319d1b008d91b18451e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637570613312317161%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vn6zrUOZvS09jvXeGhQjB%2BnWGjKMRHBSKaW6UzLm%2F0g%3D&reserved=0.