Closed Tiwas closed 5 years ago
labrys
commented
5 years ago @Tiwas What branch are you running? I assume master.
Can you try the following:
cd C:\SickRage\Scripts\nzbToMedia
python cleanup.py
dir libsAnd post the results of the dir command.
Tiwas
commented
5 years ago Yes, I'm on master.
Here's the output: C:\SickRage\Scripts\nzbToMedia>python cleanup.py
-- Cleaning bytecode -- Removing libs/enum/LICENSE Removing libs/enum/README Removing libs/rarfile1/LICENSE Removing libs/rarfile1/Makefile Removing libs/rarfile1/PKG-INFO Removing libs/rarfile1/doc/Makefile Removing libs/rarfile1/test/Makefile
Removing libs/enum/LICENSE Removing libs/enum/README Removing libs/rarfile1/LICENSE Removing libs/rarfile1/Makefile Removing libs/rarfile1/PKG-INFO Removing libs/rarfile1/doc/Makefile Removing libs/rarfile1/test/Makefile
-- Cleaning folders: ('libs', 'core') -- Removing core/ Removing libs/
-- Cleanup finished --
C:\SickRage\Scripts\nzbToMedia>dir libs Volume in drive C has no label. Volume Serial Number is 4040-9DEC
Directory of C:\SickRage\Scripts\nzbToMedia
File Not Found
Tiwas
commented
5 years ago Extracted the tar into the directory (again) and ran cleanup.py at once. Same result as above.
labrys
commented
5 years ago Ok so there's an issue with the cleanup.. I'll hotfix it shortly.
Tiwas
commented
5 years ago Seems that way, yes.
labrys
commented
5 years ago So I see what the problem is, but I can't reproduce it here. The cleanup script deleted the core and libs directories. Can you try something for me?
cd C:\SickRage\Scripts\nzbToMedia
git pull origin master
python cleanup.py
dir libsLet me know if the directory still exists after that.
Tiwas
commented
5 years ago Seems I need to force it. I'll unpack the tar once more after this.
C:\SickRage\Scripts\nzbToMedia>git pull origin master From https://github.com/SickChill/SickChill
C:\SickRage\Scripts\nzbToMedia>python cleanup.py
-- Cleaning bytecode --
No bytecode to clean
-- Cleaning folders: ('libs', 'core') -- No folders to clean
-- Cleanup finished --
C:\SickRage\Scripts\nzbToMedia>dir libs Volume in drive C has no label. Volume Serial Number is 4040-9DEC
Directory of C:\SickRage\Scripts\nzbToMedia
File Not Found
Tiwas
commented
5 years ago I downloaded the latest tarball and unpacked it into the nzbToMedia directory. Then ran the cleanup.py, but it still deleted my files. Are there any command I can use to force a pull preferrably without overwriting my config? If not, I can backup the config if you help me out with the correct commands to force a pull.
labrys
commented
5 years ago If its doing it with the latest tarball I'll see if I can reproduce it here locally. I assume you're running master on windows, correct?
Tiwas
commented
5 years ago That's correct. Master on windows 10
labrys
commented
5 years ago Can you try running git branch and git remote from the nzbToMedia directory? Nearest I can guess is you have a source install that has been initialized as a git repository, but it's not tied to upstream.
Tiwas
commented
5 years ago C:\SickRage\Scripts\nzbToMedia>git branch
C:\SickRage\Scripts\nzbToMedia>git remote origin
labrys
commented
5 years ago Can you post the results of git log -n 1? Thanks for all your assistance with this.
Tiwas
commented
5 years ago C:\SickRage\Scripts\nzbToMedia>git log -n 1 commit abc6aab554715e57cf1668627a1f57f5b1ed4588 (HEAD -> master, origin/master, origin/develop, origin/HEAD) Author: SickChill miigotu@gmail.com Date: Mon Dec 24 08:11:52 2018 +0000
Update translations (build 10027) [skip ci]I'm the one who should be thankful. After all, I'm helping you help me (us) even more with an awesome script :D
labrys
commented
5 years ago So it looks like you have a git install and that it is pointing at a custom fork. Can you run git remote -v and post the results.
Tiwas
commented
5 years ago Hmmm...could it be that it's looking at the .git file from the parent directory?
C:\SickRage\Scripts\nzbToMedia>git remote -v origin https://github.com/SickChill/SickChill.git (fetch) origin https://github.com/SickChill/SickChill.git (push)
labrys
commented
5 years ago That's what it looks like. From the nzbtomedia folder try dir /ah if you see a .git folder then it's a separate repository (not likely looking at the remote from above).
Tiwas
commented
5 years ago File not found. I did install this from the tarball, but never thought that would be an issue (might add that to the install directions?). Is there a good way to resolve this? I've backed up my config, so I can force an install with git (if I get the necessary commands ;) )
labrys
commented
5 years ago I have a path forward for the fix now. I can update the git cleanup to check that the nzbtomedia project root is a git repo before it executes.
Tiwas
commented
5 years ago I have a path forward for the fix now. I can update the git cleanup to check that the nzbtomedia project root is a git repo before it executes.
Can you also make it a git repo if it's not?
labrys
commented
5 years ago I would prefer not to as that could break some installs.
I could add an option that could be run manually to convert it to a git repository, if desired.
If you would be interested in it can you create a new issue as a feature request?
labrys
commented
5 years ago If you could test this before I merge it to master: https://github.com/clinton-hall/nzbToMedia/releases/tag/11.8.1-rc.1 Edit: Updated tag
Tiwas
commented
5 years ago Was this the expected reponse?
C:\SickRage\Scripts\nzbToMedia>python cleanup.py Directory is not a git repository
-- Cleanup finished --
labrys
commented
5 years ago Yes. However I think I might modify it to clean the bytecode regardless as that will always be a safe operation. Let me post a change for you to try.
labrys
commented
5 years ago If you could try RC2, it would be appreciated: https://github.com/clinton-hall/nzbToMedia/releases/tag/11.8.1-rc.2
Tiwas
commented
5 years ago First run it removed a whole bunch of files. The second run didn't remove any. From what I can see it's still functional.
labrys
commented
5 years ago Perfect, thanks!
Tiwas
commented
5 years ago Tested it out, and it seems to work fine on my test-download. Thanks a lot :)
Tiwas
commented
5 years ago I would prefer not to as that could break some installs. I could add an option that could be run manually to convert it to a git repository, if desired. If you would be interested in it can you create a new issue as a feature request?
Is it even necessary, or will it just download the tarball if it's not a git repo? Maybe just include details in the setup guide instead? "This is how you install from the tarball, this is how you make it a git repo"? From what I've seen it will update itself just fine (until the bad script wiped it).
labrys
commented
5 years ago I don't really think its necessary. But yes I would like to add manual update information to the wiki.
Tiwas
commented
5 years ago Cool! Then I won't create an issue asking for it. It hasn't been necessary for me yet, and if it's in the wiki people can do it themselves. Even better, by not making a script for it it will be less maintenance for you and more time to focus on "real" problems and issues.
Thanks for awesome support today!
labrys
commented
5 years ago No problem and thanks a lot for all the assistance narrowing down the cause.
Got the following while post processing a download this morning:
I tried downloading the tar directly from here and overwriting my current files, but it just jumps straight to "cleanup" where the files deleted above are deleted again.