search

clinton-hall / nzbToMedia

Provides NZB and Torrent postprocessing To CouchPotatoServer, SickBeard/SickRage, HeadPhones, Mylar and Gamez
GNU General Public License v3.0
674 stars 176 forks source link

Fix a bug about wrong order of function arguments #1889

Closed LostBenjamin closed 2 years ago

LostBenjamin commented 2 years ago

Hi,

This pull request is a fix to a potential bug about wrong order of function arguments at libs/common/mutagen/flac.py. Please check the changes.

Best, Jingxuan

clinton-hall commented 2 years ago

Thanks for this. Can you confirm what issue this is causing, or likely to cause? Since the args are named, I am not sure the order is going to be a problem here?

I note that this code actually comes from https://github.com/quodlibet/mutagen/blob/master/mutagen/flac.py#L283 It has not been updated there, and I would have expected any likely issues to be found there first.

LostBenjamin commented 2 years ago

When calling super, the first argument should be the class name (see this).

This issue was found by our automated tool statically. Therefore, I do not have a test and do not know what the issue is likely to cause.

I created another PR in the original repo. Perhaps they know more about it.

clinton-hall commented 2 years ago

Thanks. I have merged this now.