Open ihassin opened 9 years ago
@garymabin Is this currently in place? Can you point me to the test that proves this?
@egwuma: Do we want a snapshot of SOH or history also? If history is needed, how far in the past do you want the server to go? It only a snapshot is retrieved, then it's much simpler, but a newly installed app will not be able to generate historical reports.
@ Bin/ Itamar, we really do not need historical data of the SOH on re-installation of the app, a snap shot of the last SOH synced to the server will suffice to kick start the app. Yes this feature is currently in place. Egwuma
@egwuma, There are all kinds of Monthly reports in the "Reports" category, Don't we need them to be correctly presented after the app's re-installation? I mean the activities about all the commodities is retrieved every time the app started for now.
Currently the system is set up to only retrieve the SOH on re-installation, history of activities are not retrieved.
Perfect.
Thanks, Itamar
On Oct 9, 2015, 9:06 AM -0400, chai-lmisnotifications@github.com, wrote:
Currently the system is set up to only retrieve the SOH on re-installation, history of activities are not retrieved.
— Reply to this email directly orview it on GitHub(https://github.com/clintonhealthaccess/chailmis-android/issues/257#issuecomment-146866282).
Egwuma says: "Currently the system is set up to only retrieve the SOH on re-installation, history of activities are not retrieved."
But Bin Ma says: "I mean the activities about all the commodities is retrieved every time the app started for now."
So it seems there is a difference between the desired and actual behavior. I am also a bit surprised however that only the SOH is supposed to be pulled over, I believe there is other data needed by the app at startup.
I saw a message that said that a reinstalled tablet does not need the history records, so I am assuming that it would need to only set SOH from the server's snapshots. OR get all the translations from the server and calculate current SOH as it's receiving number from the server (I hope that's not the case, I'd rather have a snapshot retrieval API on the server).
@egwuma - please weigh in.
I think the QA URL more generally is in the github readme.
@all - we have the URL in #256. No need to answer this question anymore.
As egwuma commented, We will only get the latest SOH snapshot every time the app starts. And I will check whether the App saves the latest SOH snapshot correctly, then we can calculate the new SOH based on the previous one.
@garymabin please commence work on this while we wait for QA to compete on the others. Thanks!
[update] I confirm that the app will save the latest SOH snapshot when starting, so the SOH will be calculated based on a right values, even if it is reinstalled
Excellent!
On Oct 12, 2015, at 21:49, Bin Ma notifications@github.com wrote:
[update] I confirm that the app will save the latest SOH snapshot when starting, so the SOH will be calculated based on a right values, even if it is reinstalled
— Reply to this email directly or view it on GitHub https://github.com/clintonhealthaccess/chailmis-android/issues/257#issuecomment-147571324.
can only test this when the server side "carry forward" function is complete
Why can’t we confirm:
Scenario: Querying the server for current information Given the server has "5" items of type "A" When I re-install the app on the tablet Then the SOH shown on the tablet for item of type "A" is "5" for my clinic
For this story, I am not worried about the validity of the server’s A’s stock value of 5. Just that it gets transmitted to the app upon re-install.
What do you think? Itamar
On Oct 13, 2015, at 05:13, chai-lmis notifications@github.com wrote:
can only test this when the server side "carry forward" function is complete
— Reply to this email directly or view it on GitHub https://github.com/clintonhealthaccess/chailmis-android/issues/257#issuecomment-147657590.
When you uninstall and re-install the app, the SOH data is retrieved from the server (based on the data synced from the app), however if the data is not carried forward to the next day (when the re-install is done) then the SOH data on the server is 0 for all unchanged SOH values.
HISP NG is working on completing this feature tomorrow, so we should be able to do an end to end test then.
@chai-lmis We should still be able to test it same day right? I.e. wait for the sync, uninstall and reinstall within say 30 mins. It should pick up that value from the server.
Tested: Not OK. App when uninstalled and reinstalled, all commodities SOH are zero, though there are SOH values on the server.
Thanks Egwuma. We'll look into it. @bin: please insert logs that show the problem and paste them here prior to trying to fix this.
Thanks, Itamar
On Oct 19, 2015, 5:55 AM -0400, chai-lmisnotifications@github.com, wrote:
Tested: Not OK. App when uninstalled and reinstalled, all commodities SOH are zero, though there are SOH values on the server.
— Reply to this email directly orview it on GitHub(https://github.com/clintonhealthaccess/chailmis-android/issues/257#issuecomment-149170861).
I will wait for the server to update from tonight's transactions and will reinstall once that is done and verify correct values
Reinstalled app. All quantities were zero. Clicked on 'sync', got success message, yet all quantities stayed at zero.
This is blocked from being tested till #251 is completed
tested ok: re-installed apk and values on the server synced to the client
Scenario: Querying the server for current information Given the server has "5" items of type "A" When I re-install the app on the tablet Then the SOH shown on the tablet for item of type "A" is "5" for my clinic