clintonrost / theme-firefox-devtools

Syntax coloring based on Firefox Developer Tools
3 stars 3 forks source link

Contrast issues on nested JSON objects #2

Open Monstarrrr opened 2 years ago

Monstarrrr commented 2 years ago

image

First of, I don't think it is a good idea to have different colors based on how deep an object is, it should remain the same color in my opinion. Regardless, there is a contrast issue starting at 4 levels down, it's a lot more noticeable while using any sort of blue light filter in which case the text literally becomes invisible.

I love this theme and I would love to see a fix for this!

Thank you in advance

clintonrost commented 2 years ago

Monstarrrr, thank you for finding this. I had a quick look at the code and I'll get a fix out shortly.

If you need an immediate fix, you can add the following to your VS Code settings:

"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "name": "JSON Value: String",
      "scope": "source.json string.quoted.double.json",
      "settings": {"foreground": "#FF97E9"}
    },
    {
      "name": "JSON Value: Number",
      "scope": ["source.json constant.numeric.json", "constant.language.json.comments"],
      "settings": {"foreground": "#86de74"}
    },
    {
      "name": "JSON Key",
      "scope": ["source.json support.type.property-name.json"],
      "settings": {"foreground": "#46AFE3"}
    }
  ]
}