fix bug with selecting correct class name from type mapping values

clio / polymorphic_integer_type

MIT License

37 stars 35 forks source link

fix bug with selecting correct class name from type mapping values #37

Closed Drew-Goddyn closed 3 years ago

Drew-Goddyn commented 3 years ago

Fix bug in getting the value's class name. In 5.1 we don't have access to #klass so need to call #class on the value. In 5.2 we have a helper method which works with relations.

I also am adding back a spec I accidentally removed in a merge conflict.

Drew-Goddyn commented 3 years ago

I believe this is the correct fix even if I don't fully understand it. Green CI in themis 5.1: https://github.com/clio/themis/pull/56519

and I confirmed it fixed the underlying issue originally reported here though I'll be testing whether there were any knock on effects in 5.2 by running a full CI there shortly