Make mysqlclient an optional dependency

clips / pattern

Web mining module for Python, with tools for scraping, natural language processing, machine learning, network analysis and visualization.

https://github.com/clips/pattern/wiki

BSD 3-Clause "New" or "Revised" License

8.74k stars 1.58k forks source link

Make mysqlclient an optional dependency #250

Open willprice opened 5 years ago

willprice commented 5 years ago

MySQL shouldn't be a core dependency, I've moved it to an extra package which can be installed as pip install pattern[mysql] if users wish to install with mysql support.

coveralls commented 5 years ago

Coverage decreased (-0.8%) to 67.472% when pulling 3b77852c51d1e80b17d9abba0be5efad6a2fd7a5 on uob-vil:master into 5b85d998c30ddc6772b56310713530224466083a on clips:master.

gutomaia commented 5 years ago

zh0uquan commented 5 years ago

kylemcdonald commented 5 years ago

thank you. i tried to get pattern running on mac with this:

brew install mysql-client
pip3 install pattern

But I couldn't get it to work. This works though:

pip3 install git+https://github.com/uob-vil/pattern.git

tuky commented 5 years ago

It would be awesome to see this happen! :-)

Sjoerd82 commented 3 years ago

Mysql really complicates the installation, as it turns out installing the myssqlclient on a windows machine is non trivial. Any luck on removing this dependency? I've linked some related issues which can all be closed when this is resolved.

ndvbd commented 1 year ago

I get:

File "/usr/lib/python3.10/zipfile.py", line 1267, in init self._RealGetContents() File "/usr/lib/python3.10/zipfile.py", line 1334, in _RealGetContents raise BadZipFile("File is not a zip file") zipfile.BadZipFile: File is not a zip file

sanmai-NL commented 1 year ago

@tom-de-smedt Can you please merge this or mark the GitHub project as Archived?

gokulnath-prabakaran-zoomrx commented 6 months ago

When will this issue be resolved?