search

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.
https://cliqz.com
Apache License 2.0
179 stars 38 forks source link

fix #201 #202

Closed hendrikmuhs closed 7 years ago

hendrikmuhs commented 7 years ago

For memory limits < 200MB the old implementation caused an underflow, ending in wrong memory calculation.

@narekgharibyan

hendrikmuhs commented 7 years ago

I suggest to lower the memory limits for unit tests in the 0.2 branch to avoid merge trouble. There we can also re-enable CPP testing for Mac.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.143% when pulling e661df1dc650500ec88f1e95ff95c6f214a3fc4f on hendrikmuhs:fix-#201 into 99608895bf45cc6dfac3f61052bfd189c0bcc269 on cliqz-oss:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.143% when pulling e661df1dc650500ec88f1e95ff95c6f214a3fc4f on hendrikmuhs:fix-#201 into 99608895bf45cc6dfac3f61052bfd189c0bcc269 on cliqz-oss:master.

narekgharibyan commented 7 years ago

@hendrikmuhs Agree.

LGTM