search

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.
https://cliqz.com
Apache License 2.0
179 stars 38 forks source link

0 2 cleanup #172 rebase2 #204

Closed hendrikmuhs closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 87.876% when pulling 907d085b8c17009b735f61db72c083565025a628 on hendrikmuhs:0_2_cleanup-#172-rebase2 into 14eef149680d20dc383a8c48cfd2f7ccf61d3630 on cliqz-oss:0_2_cleanup.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 88.017% when pulling 5cfa9a57c38aa50bdcd562f6c5f53bf82d6a2469 on hendrikmuhs:0_2_cleanup-#172-rebase2 into 14eef149680d20dc383a8c48cfd2f7ccf61d3630 on cliqz-oss:0_2_cleanup.

hendrikmuhs commented 7 years ago

@narekgharibyan Can you review?

From where we stopped last time, this is the code I added for making parameter parsing a bit easier:

https://github.com/hendrikmuhs/keyvi/blob/5cfa9a57c38aa50bdcd562f6c5f53bf82d6a2469/keyvi/src/cpp/dictionary/util/configuration.h https://github.com/hendrikmuhs/keyvi/blob/5cfa9a57c38aa50bdcd562f6c5f53bf82d6a2469/keyvi/tests/cpp/dictionary/util/configuration_test.cpp

narekgharibyan commented 7 years ago

LGTM