Travis cmake

[narekgharibyan]

@hendrikmuhs this fixes #182

Just don't know how to be with deb packaging, also docs needs to be updated.

[coveralls]

Coverage decreased (-22.3%) to 63.825% when pulling 66c223a2d160a0b03d2f3f9233c4ee57b85d4687 on narekgharibyan:travis-cmake into 04c615076dcb3b8784c293576282bdf20dac4ad1 on cliqz-oss:master.

[narekgharibyan]

And looks I broke coveralls :/

[hendrikmuhs]

Yes, coverage is an own mode or 'build type' as it is called in cmake.

I wonder if the cmake file already covers everything that scons had. Looks a bit to simple for me. ;-)

E.g. there are also some TPIE flags scons sets.

I will try your PR next week and give feedback. Lets ensure that we get everything right before the switch.

[coveralls]

Coverage decreased (-22.3%) to 63.825% when pulling f91801623620c8d0a37001241d8d2877fddd96cc on narekgharibyan:travis-cmake into 04c615076dcb3b8784c293576282bdf20dac4ad1 on cliqz-oss:master.

[coveralls]

Coverage increased (+0.6%) to 86.698% when pulling 7ffb6d7d5feb5e57ef37422bf89a605ccef4267e on narekgharibyan:travis-cmake into 04c615076dcb3b8784c293576282bdf20dac4ad1 on cliqz-oss:master.

[hendrikmuhs]

Nice, works for me.

@narekgharibyan anything missing except the doc changes? Any chance to move the CMakeLists.txt into the keyvi subfolder?

[narekgharibyan]

@hendrikmuhs Thanks!

remaining things are:

• doc update
• removing Scons scripts
• open question about Debian packaging: https://github.com/cliqz-oss/keyvi/blob/master/keyvi/deb/SConscript, is it fine to remove it ?

regarding to CMakeLists.txt location: I checked and still it's a bit tricky to import project into CLion, I prefer to keep it in the root, but that's not a mandatory.

[hendrikmuhs]

@narekgharibyan

This debian packaging you mentioned is outdated, so just remove it, no problem. The real debian packaging stuff is in the keyvi-package repo. It needs adjustment:

https://github.com/cliqz-oss/keyvi-package/blob/master/debian/rules

... but this can be done afterwards IMO.

As for the CMakeLists: I do not understand it completely - still haven't tried CLion: You need it in root to have 1 project for both keyvi and pykeyvi? If the file is located under keyvi, you would not be able to see pykeyvi? Is that ritght?

Actually that's how I work using eclipse/pycharm. I have 2 projects there: a keyvi and a pykeyvi project. As both have there own build system I also see them as 2 projects.

Anyway, as it is just 1 file, I do not insist on putting it into the keyvi subfolder although I believe it belongs there.

[narekgharibyan]

@hendrikmuhs exactly!

[narekgharibyan]

@hendrikmuhs The compile section in file https://github.com/cliqz-oss/keyvi/blob/master/keyvi/README.md#compile looks to me a bit incorrect, as we are not compiling C++ library, rather we compile 3rd party lib and create standalone executables and unit tests executable. What do you think ?

[coveralls]

Coverage increased (+0.6%) to 86.698% when pulling 9c983f45f9940d30a6194de790bd6152a13fa6cb on narekgharibyan:travis-cmake into 04c615076dcb3b8784c293576282bdf20dac4ad1 on cliqz-oss:master.

[coveralls]

Coverage increased (+0.6%) to 86.698% when pulling 9c983f45f9940d30a6194de790bd6152a13fa6cb on narekgharibyan:travis-cmake into 04c615076dcb3b8784c293576282bdf20dac4ad1 on cliqz-oss:master.

[hendrikmuhs]

@narekgharibyan Correct, in the very early days it was a library, but this isn't the case for a long time (not even sure if it ever was the case for 'keyvi' or the predecessor).

Anyway, should be rephrased, good catch.

[coveralls]

Coverage increased (+0.6%) to 86.698% when pulling a0e7f82bb3a21d69eaae8470ad3983fcb8c46a2b on narekgharibyan:travis-cmake into 04c615076dcb3b8784c293576282bdf20dac4ad1 on cliqz-oss:master.

[hendrikmuhs]

LGTM!

(can you do a squash merge for less history polluting)