search

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.
https://cliqz.com
Apache License 2.0
179 stars 38 forks source link

add a simple test for int dictionaries #216

Closed hendrikmuhs closed 7 years ago

hendrikmuhs commented 7 years ago

I realized that I forgot to check in 1 file when separating completion and int dictionary.

Unfortunately this was not catched as it is part of code generation and it works without the file. So I added a test that should trigger the problem. If I am right CI on this 1st commit should fail.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 87.567% when pulling 327d13f6606a43cf4854810b793fe8a0c85a61a4 on hendrikmuhs:0_2_cleanup_missing_file into 712fb0528626f57c77bf16957b8f4d897be7a37d on cliqz-oss:0_2_cleanup.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 87.567% when pulling 327d13f6606a43cf4854810b793fe8a0c85a61a4 on hendrikmuhs:0_2_cleanup_missing_file into 712fb0528626f57c77bf16957b8f4d897be7a37d on cliqz-oss:0_2_cleanup.

narekgharibyan commented 7 years ago

LGTM

Just wondering why it did not fail for all builds.

hendrikmuhs commented 7 years ago

@narekgharibyan

I think I pushed the 2nd commit, aka the fix, to fast, so that the other builds already picked up the fix.