search

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.
https://cliqz.com
Apache License 2.0
179 stars 38 forks source link

Proper debugline #220

Closed hendrikmuhs closed 7 years ago

hendrikmuhs commented 7 years ago

@narekgharibyan

Just the debugline changes

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.698% when pulling f37f8e587d9bf8f8044253dc6899339cfe53bfcb on hendrikmuhs:proper-debugline into 247efd3f68590262376427f3cd20362bcd2e17b8 on cliqz-oss:master.

narekgharibyan commented 7 years ago

LGTM

What about CMakeLists location and coveralls ?

hendrikmuhs commented 7 years ago

Unfortunately the sed rewrite is still necessary, I tried it on the original PR. So I was wrong with my guess.

Will add the CMakeLists change.

narekgharibyan commented 7 years ago

Ok then I'm merging this PR.

Regarding to sed elimination: One possible solution can be copying keyvi dir instead of linking, and then using gcov -s option. On my Mac Book, copying of whole keyvi takes about 0.3 sec