keyvi cli params fix for 0.2 branch

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.

https://cliqz.com

Apache License 2.0

179 stars 38 forks source link

keyvi cli params fix for 0.2 branch #221

Closed narekgharibyan closed 7 years ago

narekgharibyan commented 7 years ago

@hendrikmuhs This PR includes:

keyvi cli params fix (memory limit)
switch to cmake: for --disable-deprecated option I thought there is no need to introduce another CMake build_type and we can specify it as using CMake's -D CMAKE_CXX_FLAGS=... option

Please, let me know what you think about.

coveralls commented 7 years ago

Coverage increased (+0.6%) to 88.202% when pulling 118643f60b5e7cf6f761979321f1fcc76c77962e on narekgharibyan:0_2_cleanup into 54d3b5c19123addbf9708688b9494fe08c5d0af2 on cliqz-oss:0_2_cleanup.

hendrikmuhs commented 7 years ago

LGTM

I agree regarding the deprecation, this is simple and good, no need for a new build type.