Do Not Merge! Keyvi server rebase

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.

https://cliqz.com

Apache License 2.0

179 stars 38 forks source link

Do Not Merge! Keyvi server rebase #223

Closed narekgharibyan closed 7 years ago

narekgharibyan commented 7 years ago

@hendrikmuhs

I did refresh/rebase KeyVi-server branch with recent changes. Please have a look, and if all good I'll push this code into upstream:keyvi-server branch.

Note: pypy builds are failing, but decided do not spend a time on it for now.

hendrikmuhs commented 7 years ago

@narekgharibyan

This PR is on master, I guess you wanted to open it against keyvi-server?

narekgharibyan commented 7 years ago

I opened it intentionally on master so you can see the diff (but I'll not merge it). When opened on keyvi-server branch, the diff is about 500 files, and it is not mergeable.

hendrikmuhs commented 7 years ago

ok, but that diff just shows me what is on keyvi-server. I do not get your intent.

Let's chat about it offline (once I fixed the mess on my skype account).

coveralls commented 7 years ago

Coverage remained the same at 86.698% when pulling 33b5ec8cc73a9190002931d699e5ff607c4f5ab4 on narekgharibyan:keyvi-server into 33f83e93969fe593bca09b202f727f88a81ab3f7 on cliqz-oss:master.

coveralls commented 7 years ago

Coverage remained the same at 86.698% when pulling d687afdfc97002cf12ae172f769647fb90424873 on narekgharibyan:keyvi-server into 33f83e93969fe593bca09b202f727f88a81ab3f7 on cliqz-oss:master.