Fix CLI dump not working in py3

cliqz-oss / keyvi

Keyvi - a key value index that powers Cliqz search engine. It is an in-memory FST-based data structure highly optimized for size and lookup performance.

https://cliqz.com

Apache License 2.0

179 stars 38 forks source link

Fix CLI dump not working in py3 #229

Closed simonalger closed 7 years ago

simonalger commented 7 years ago

dump() was not working in py3 because file object cannot write() a bytes object. Fix: decode bytes object to string before write()ing

hendrikmuhs commented 7 years ago

@simonalger Thanks!

We should have some tests for this, I opened #230.

coveralls commented 7 years ago

Coverage remained the same at 88.215% when pulling 63f672c8b48dfb08d960c0372858e76e45237025 on simonalger:master into fd97ae5eed855165043595b552a6504100bba114 on cliqz-oss:master.